This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Apply config hooks to previously defined groups. #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
apply-hooks-to-groups-defined-before-them
branch
from
96866d6 to
3af9007
Compare
myronmarston
force-pushed
the
apply-hooks-to-groups-defined-before-them
branch
from
3af9007 to
84e92e2
Compare
|
Can someone from @rspec/rspec review this? |
|
Awesome. |
JonRowe
added a commit
that referenced
this pull request
Mar 6, 2016
…ore-them Apply config hooks to previously defined groups.
myronmarston
added a commit
that referenced
this pull request
Mar 8, 2016
myronmarston
added a commit
that referenced
this pull request
Mar 8, 2016
…nition hooks. This is important so that if you load any support files that define hooks from within a definition hook, it can apply the hooks to the already-defined example groups (as is now supported via #2189). Without this change, the current group being defined is not eligible to have newly loaded hooks applied to it.
myronmarston
added a commit
that referenced
this pull request
Mar 8, 2016
…nition hooks. This is important so that if you load any support files that define hooks from within a definition hook, it can apply the hooks to the already-defined example groups (as is now supported via #2189). Without this change, the current group being defined is not eligible to have newly loaded hooks applied to it.
myronmarston
added a commit
that referenced
this pull request
Mar 8, 2016
…nition hooks. This is important so that if you load any support files that define hooks from within a definition hook, it can apply the hooks to the already-defined example groups (as is now supported via #2189). Without this change, the current group being defined is not eligible to have newly loaded hooks applied to it.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…d-before-them Apply config hooks to previously defined groups.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…nition hooks. This is important so that if you load any support files that define hooks from within a definition hook, it can apply the hooks to the already-defined example groups (as is now supported via rspec#2189). Without this change, the current group being defined is not eligible to have newly loaded hooks applied to it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1939.