This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Get failure message from exception_presenter
#2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JonRowe |
|
I don't see anything wrong with this in theory but the spec for the HTML formatter needs to be updated... |
|
Updated this PR |
|
@JonRowe these failures seem unrelated to the work I've done |
Currently a few of the formatters get their failure message directly from the exception[1]. This commit changes the HTML formatter and gets the failure message from the `FailedExampleNotification#message_lines`, which delegates this message to the `ExceptionPresenter#message_lines`. Meaning we the HTML formatter uses the exception presenter to get the exception. 1.) https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/formatters/html_formatter.rb#L71
|
I think this PR maybe good to go as those failures have now disappeared thanks to #2249 |
|
❤️ thanks |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…ception-presenter Get failure message from `exception_presenter`
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a few of the formatters get their failure message
directly from the exception[1].
This commit changes the HTML formatter and gets the failure message from the
FailedExampleNotification#message_lines, which delegates this message to theExceptionPresenter#message_lines.1.) http://bit.ly/1PNf22l