Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Load spec files in the order that files and dirs were specified in the CLI. #2253

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

myronmarston
Copy link
Member

This fixes #2247 and addresses some of the feedback from #2251.

@JonRowe
Copy link
Member

JonRowe commented Jun 1, 2016

I believe this should be an acceptable compromise between filesystem consistency and running files as expected, if you need the files within folders in a certain order you'd have to specify them as such but thats just a case of being explicit. Nice work @myronmarston

@e2
Copy link
Contributor

e2 commented Jun 1, 2016

This is so much fun :)

It's a killer feature for me.

I can create a list of files to "order" and prepend them on the command line - and those will be run first. I can have another file of "slow" files - and append them to the command line. I can also prepend failures and/or common failures.

Tons of cool options have opened up for me - so thanks a million!

❤️

…e CLI.

This fixes #2247 and addresses some of the feedback from #2251.
@myronmarston myronmarston force-pushed the myron/load-spec-files-in-cli-order branch from 3f2b5dd to b6c84bc Compare June 1, 2016 05:29
@e2
Copy link
Contributor

e2 commented Jun 1, 2016

Deduplication works great :)

Can't wait to use this on a more heavier project tomorrow!

@myronmarston myronmarston merged commit aed8a07 into master Jun 1, 2016
@myronmarston myronmarston deleted the myron/load-spec-files-in-cli-order branch June 1, 2016 05:53
mvidner added a commit to yast/yast-rake that referenced this pull request Jul 22, 2016
to undo the nondeterminism introduced in rspec-3.5.0
rspec/rspec-core#2253
MatheusRich pushed a commit to MatheusRich/rspec-core that referenced this pull request Oct 30, 2020
…-order

Load spec files in the order that files and dirs were specified in the CLI.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: order of files given at command line is not preserved (when ordered)
3 participants