This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove unused arg #2254
Merged
Remove unused arg #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the `_exception` arg passed to `DocumentationFormatter#failure_output` is a relic of the past [1]. So I think it's safe to remove it. 1.) 79be9b3#diff-6651211a081b5ea464e033bf7c8e061cL46
|
I think this is ok to remove, not going to add a change log because internal refactoring etc. |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Remove unused arg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the
_exceptionarg passed toDocumentationFormatter#failure_outputis a relic of the past [1]. So I think it's safe to remove it.1.) 79be9b3#diff-6651211a081b5ea464e033bf7c8e061cL46