This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Shared example group inclusion changes #2256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you did `config.include :not_a_module, :some_meta`, and defined an example with `:some_meta` metadata, the ruby type error would be raised when the example was being prepared to run, and would lead to other errors due to RSpec’s example setup and teardown not completing. It was quite confusing. Instead, we fail fast at the point of the mistake. Also, we apply this to `config.extend` and `config.prepend` for consistency.
myronmarston
force-pushed
the
myron/fix-1790
branch
2 times, most recently
from
f34c874 to
9139c61
Compare
This simplifies things, makes things more consistent, and prepares us to be able to better handle metadata as per discussion in #1790.
myronmarston
force-pushed
the
myron/fix-1790
branch
from
9139c61 to
6e5a48f
Compare
This ensures that if we need to re-configure a group hooks registration happens appropriately. Also, do the same for example configuration.
myronmarston
force-pushed
the
myron/fix-1790
branch
7 times, most recently
from
5ef3a63 to
0ddbd25
Compare
myronmarston
changed the title
|
OK, @rspec/rspec -- I've taken this PR as far as I plan to take it. Can someone (or multiple people) review it please? I'd love to get this in RSpec 3.5. |
|
👍 |
myronmarston
force-pushed
the
myron/fix-1790
branch
from
05ca6bd to
8bc35e5
Compare
- Takes care of preserving metadata inheritance. - Takes care of re-applying filtered config items like module inclusions and hooks. This is necessary for #1790.
Previously, it always triggered auto-inclusion based on matching metadata. The option allows you to opt-in to having it add the metadata to included groups and examples instead. - Closes #1790 (this is the last thing necessary for it). - Addresses #1762. - Addresses user confusion reported in: - rspec/rspec-rails#1241 - rspec/rspec-rails#1579
myronmarston
force-pushed
the
myron/fix-1790
branch
from
8bc35e5 to
3589ab5
Compare
|
...and now this is green. @samphippen: is your 👍 a way of saying "LGTM" or just saying you're a fan of the feature as a whole? |
|
Yeah, It's an LGTM! Merge Away 😄 |
|
Haha...for such a large PR I was expecting more feedback :). One thing I'm not quite sure on is if the names I've chosen for things are best. Thoughts? |
|
I think the names are good, and you've done a good job of documenting them. With these things, we could agonise on the names, but I feel like they fill the purpose. I don't have anything obviously better. I did wonder why you didn't use a boolean initially, but I think using symbols is better :) |
myronmarston
added a commit
to rspec/rspec-support
that referenced
this pull request
Jun 5, 2016
Now that rspec/rspec-core#2256 has been merged.
| @@ -24,7 +24,7 @@ Metrics/LineLength: | |||
|
|
|||
| # This should go down over time. | |||
| Metrics/MethodLength: | |||
| Max: 40 | |||
| Max: 37 | |||
JonRowe
pushed a commit
to rspec/rspec-support
that referenced
this pull request
Jun 10, 2019
Now that rspec/rspec-core#2256 has been merged.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Shared example group inclusion changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a number of changes for #1790.
Still TODO:
RSpec.shared_examplesdoes.