This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Include SPEC_OPTS in bisect reproduction command #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the following command:
SPEC_OPTS="--bisect --seed 125" rspec blah_spec.rb
would return a repro command something like
rspec blah_spec.rb[1:2,1:4]
However, this won't run in the correct order without the seed. This patch
includes SPEC_OPTS in the bisect reproduction command, minus the `--bisect`
flag.
By default, cukes using aruba to run commands are given an environment with
SPEC_OPTS="-r/path/to/features/support/require_expect_syntax_in_aruba_specs.rb",
which ensures that `should` and `should_not` are not used in the examples.
Now that SPEC_OPTS is included in the bisect reproduction command, however,
this setting shows up in the final output, breaking the existing assertions.
To prevent this I've added a new tag, `@with-clean-spec-opts`, and added this
tag to the logic controlling whether the above file is loaded.
|
This LGTM! |
myronmarston
added a commit
that referenced
this pull request
Jun 17, 2016
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…n-bisect-repro-command Include SPEC_OPTS in bisect reproduction command
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the following command:
would return a repro command something like:
To reliably run in the correct order, we need to include the seed from SPEC_OPTS - this patch adds this to the repro command, to now return:
To keep the cukes passing I've had to exclude the bisect feature from the
should/should_notprevention; this uses SPEC_OPTS to load a support file, which then shows up in the repro command produced by the cukes.Rather than add the
@allow-should-syntaxtag to these cukes I've introduced a new@with-clean-spec-optstag to try to communicate the intention better, even though it just controls the same hook as the existing tag. Does that seem reasonable?