This repository was archived by the owner on Nov 30, 2024. It is now read-only.
PR 2280 followups #2284
Merged
PR 2280 followups #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| until groups.empty? | ||
| group = groups.shift | ||
| def add_hook_to_exisiting_matching_groups(meta, scope, &block) |
|
This looks great - traversing the example group hierarchy is much clearer 👍 |
- Use a functional style using recursion instead of mutating a `groups` array imperatively. I find a functional style easier to reason about. - Split off the hook-specific logic, but preserve the general traversal logic. - Remove duplication of `Metadata.build_hash_from`. - Only call `Metadata.build_hash_from` if needed. If we are dealing with an :example hook there is no need.
myronmarston
force-pushed
the
myron/pr-2280-followups
branch
from
58eaac6 to
0c700e8
Compare
|
@rspec/rspec can someone review this? Then I'll merge and get this (and #2280) released in 3.5.1. |
|
Good work! |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
PR 2280 followups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eugeneius -- can you review my refactoring here and confirm my refactoring here is functionality equivalent to what you had before?