Updates from rspec-dev (2016-07-14) #2293
Conversation
JonRowe
force-pushed
the
update-travis-build-scripts-2016-07-14-for-master
branch
from
aed781d to
b32a5cc
Compare
JonRowe
force-pushed
the
update-travis-build-scripts-2016-07-14-for-master
branch
from
baa5250 to
b985c4f
Compare
Doesn't seem to work at all on 9.1.2.0
|
The same broken backtrace filtering that had to be pended in the specs needed to be pended in the cukes, ok to merge @myronmarston ? |
| @@ -28,7 +28,7 @@ function run_specs_and_record_done { | |||
|
|
|||
| # rspec-core needs to run with a special script that loads simplecov first, | |||
| # so that it can instrument rspec-core's code before rspec-core has been loaded. | |||
| if [ -f script/rspec_with_simplecov ]; then | |||
| if [ -f script/rspec_with_simplecov ] && is_mri; then | |||
There was a problem hiding this comment.
Does simplecov not work on JRuby anymore?
There was a problem hiding this comment.
I'm not sure we've ever tried to run it before, our other JRuby modes report themselves as < 2 so miss this anyway, but rspec-core is reporting 0% coverage on JRuby 9.1.50
|
Hmm, there's kinda a lot that you had to pend here. I don't want these things to be marked as pending and just be left that way. Do you have a plan for tackling them? |
|
Yeah I wasn't overly happy doing it but I feel as this is a build steps PR and I didn't have the time to fix them straight away, would you be happy if I opened an issue to keep track of them? |
Sure. It'd be great if the issues provided some detail about what the failure is. |
|
Ok to merge otherwise? |
Yes |
…2016-07-14-for-master Updates from rspec-dev (2016-07-14)
These are some updates, generated from rspec-dev's rake tasks.