This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Improve output from rspec -v.
#2304
Merged
+59
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/version-improvement
branch
2 times, most recently
from
d5eb656 to
80fcb24
Compare
| begin | ||
| require "rspec/#{lib_name}/version" | ||
| rescue LoadError | ||
| out.puts " - rspec-#{lib_name} not installed" |
There was a problem hiding this comment.
I'm not sure we need to bother with this, if it's not installed just don't list it?
myronmarston
force-pushed
the
myron/version-improvement
branch
from
80fcb24 to
0e0e206
Compare
Before this change, this confusing thing could happen: ``` $ gem install rspec -v 3.5.0 > /dev/null; rspec -v 3.5.1 ``` The user installed RSpec 3.5.0 but `rspec -v` prints 3.5.1. This happened because 3.5.0 of the rspec gem depends on 3.5.x of all the sub-gems, and 3.5.1 is the latest rspec-core. With this change, it now prints something like: ``` $ rspec -v RSpec 3.5 - rspec-core 3.5.1 - rspec-expectations 3.5.0 - rspec-mocks 3.5.0 - rspec-support 3.5.0 ```
myronmarston
force-pushed
the
myron/version-improvement
branch
from
0e0e206 to
e448575
Compare
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Improve output from `rspec -v`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, this confusing thing could happen:
The user installed RSpec 3.5.0 but
rspec -vprints 3.5.1.This happened because 3.5.0 of the rspec gem depends on 3.5.x
of all the sub-gems, and 3.5.1 is the latest rspec-core.
With this change, it now prints something like: