This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix issue causing our spec suite to run much slower. #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change: $ bin/rspec | egrep 'Finished|(examples.*failure)' Finished in 45.99 seconds (files took 0.89765 seconds to load) 2014 examples, 4 failures, 1 pending After this change: $ bin/rspec | egrep 'Finished|(examples.*failure)' Finished in 11.16 seconds (files took 1.16 seconds to load) 2014 examples, 4 failures, 1 pending I believe the issue was requiring 'rspec/rails/version'. Since rspec-rails is not available, rubygems would exhaustively search all my installed gems before raising `LoadError`. I have ~300 gems installed and this was quite slow. It's better to just force it to raise `LoadError` and not wait on RubyGems to do the same thing.
|
LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Fix issue causing our spec suite to run much slower.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
After this change:
I believe the issue was requiring 'rspec/rails/version'. Since
rspec-rails is not available, rubygems would exhaustively search
all my installed gems before raising
LoadError. I have ~300 gemsinstalled and this was quite slow.
It's better to just force it to raise
LoadErrorand not wait onRubyGems to do the same thing.