Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Add errors_outside_of_examples_count to JSON output #2448

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/rspec/core/formatters/json_formatter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ def dump_summary(summary)
:duration => summary.duration,
:example_count => summary.example_count,
:failure_count => summary.failure_count,
:pending_count => summary.pending_count
:pending_count => summary.pending_count,
:errors_outside_of_examples_count => summary.errors_outside_of_examples_count
}
@output_hash[:summary_line] = summary.totals_line
end
Expand Down
7 changes: 4 additions & 3 deletions spec/rspec/core/formatters/json_formatter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
:example_count => 3,
:failure_count => 1,
:pending_count => 1,
:errors_outside_of_examples_count => 0,
},
:summary_line => "3 examples, 1 failure, 1 pending"
}
Expand Down Expand Up @@ -139,13 +140,13 @@

describe "#dump_summary" do
it "adds summary info to the output hash" do
send_notification :dump_summary, summary_notification(1.0, examples(10), examples(3), examples(4), 0)
send_notification :dump_summary, summary_notification(1.0, examples(10), examples(3), examples(4), 0, 1)
expect(formatter.output_hash[:summary]).to include(
:duration => 1.0, :example_count => 10, :failure_count => 3,
:pending_count => 4
:pending_count => 4, :errors_outside_of_examples_count => 1
)
summary_line = formatter.output_hash[:summary_line]
expect(summary_line).to eq "10 examples, 3 failures, 4 pending"
expect(summary_line).to eq "10 examples, 3 failures, 4 pending, 1 error occurred outside of examples"
end
end

Expand Down