Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Mark failing examples on JRuby 9000 as pending #2455

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

yujinakayama
Copy link
Member

@yujinakayama yujinakayama commented Aug 10, 2017

They have started failing after we made ripper_supported? return true on JRuby 9.1.9.0 or later in rspec/rspec-support#326. However it's actually caused by a bug in JRuby's backtrace, neither Ripper nor our multiline snippet extraction.

jruby/jruby#4737

Failures:

  1) RSpec::Core::Formatters::ExceptionPresenter#read_failed_lines when the failed expression spans multiple lines and the line count does not exceed RSpec.configuration.max_displayed_failure_line_count returns all the lines
     Failure/Error:
       expect(read_failed_lines).to eq([
         "            expect('RSpec').to be_a(String).",
         "                           and start_with('R').",
         "                           and end_with('z')"
       ])

       expected: ["            expect('RSpec').to be_a(String).", "                           and start_with('R').", "                           and end_with('z')"]
            got: ["                           and start_with('R').", "                           and end_with('z')"]

       (compared using ==)

They are failing due to a bug in JRuby 9000.

jruby/jruby#4737
@yujinakayama
Copy link
Member Author

@rspec/rspec

@yujinakayama yujinakayama merged commit 8303659 into master Aug 12, 2017
@yujinakayama yujinakayama deleted the suppress-failing-examples-on-jruby-9000 branch August 12, 2017 01:09
MatheusRich pushed a commit to MatheusRich/rspec-core that referenced this pull request Oct 30, 2020
…-jruby-9000

Mark failing examples on JRuby 9000 as pending
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant