This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Simplify BisectFormatter using example_finished notification.
#2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/simplify-bisect-formatter
branch
from
415845d to
c9b20c1
Compare
We did not offer it when the BisectFormatter was written but it nicely simplifies it now. Also, get the expected failures in `initialize` instead of `start`.
myronmarston
force-pushed
the
myron/simplify-bisect-formatter
branch
from
c9b20c1 to
a35be9f
Compare
JonRowe
approved these changes
Jan 16, 2018
|
Nice! Much simpler now. LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Simplify BisectFormatter using `example_finished` notification.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not offer it when the BisectFormatter was written but it
nicely simplifies it now.