This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Use RSpec module on describe calls in docs #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ❤️ |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…2571) This commit was imported from rspec/rspec-core@58f3821.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've noticed that the README in https://relishapp.com/rspec/rspec-core/v/3-8/docs didn't use the
RSpecmodule on the describe call; the module is used in mostly all examples across the documentation: [1], [2], [3].I've took the opportunity to also update other places that didn't use the RSpec module.
To find those I used this regex, just in case is useful to someone:
\sdescribe [A-Z](any describe prefixed with a space where the subject starts with a capital letter, presumably a class)