Make specs and features global configuration proof

[pirj]

If a ~/.config/rspec/options file contains the following:

--color
--profile 2
--format progress
--require pry

some specs and features fail, since they are run with options that
contradict the default ones, and expectations are not met.

Example failures:

 (RSpec::Expectations::ExpectationNotMetError)
features/verifying_doubles/partial_doubles.feature:34:in `Then the output should contain "1 example, 1 failure"'
...
LoadError:
  cannot load such file -- pry


6) RSpec::Core::Formatters::ProgressFormatter produces the expected full output
...
   +Top 2 slowest example groups:
   +  pending command with block format
   +    n.nnnn seconds average (n.nnnn seconds / 2 examples) ./spec/rspec/core/resources/formatter_specs.rb:14
   +  failing spec
   +    n.nnnn seconds average (n.nnnn seconds / 2 examples) ./spec/rspec/core/resources/formatter_specs.rb:35
   +

This fixes rspec/rspec-dev#217. Similar issues affect features of rspec-mocks and rspec-expectations, will send out pull requests shortly.

NOTE: Unfortunately, this doesn't fix the issue for configuration stored in ~/.rspec. My advice is to move it over to ~/.config/rspec/options.

NOTE: Unfortunately, this doesn't fix the issue for --require pry for features.

[JonRowe]

Hm I was thinking more along the lines of modifying spec/support/sandboxing.rb to set the right configuration...

[pirj]

@JonRowe Addressed your concerns, now it's less hacky. Please take another look.

[pirj]

AppVeyor failure is unrelated.

[JonRowe]

This still isn't what I meant, we should set the config required to make specs pass, not ignore the config thats there...

[pirj]

@JonRowe I can't find a good way around some of the failing features. E.g. in my ~/.rspec (or $XDG_CONFIG_HOME/rspec/options) there's a line --format progress (or --format documentation, or any other format, no matter). If I add a step:

Given(/^a configuration file with defaults$/) do
  step %q{a file named ".rspec" with:}, "
    --no-profile
  "
end

and use it features/command_line/init.feature:25, which is:

     Then the output from `rspec` should not be in documentation format
      But the output from `rspec spec/addition_spec.rb` should be in documentation format
      But the output from `rspec spec/addition_spec.rb --format progress` should not be in documentation format

there is nothing that a I can put in that "configuration with defaults" to override the reset the global setting back to default (format for running all is in progress, format for running one is documentation), either of those fails:

features/command_line/init.feature:46:in `Then the output from `rspec` should not be in documentation format' 
...
features/command_line/init.feature:47:in `But the output from `rspec spec/addition_spec.rb` should be in documentation format' 

Do you have some hints?

[pirj]

I've already removed --require pry from my global conf. I'm more inclined to close this (and corresponding mocks and expectations PRs) and remove global configuration if I'm the only potential contributor suffering from weird failures due to global conf options.