This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Disable memory leak spec for TruffleRuby #2685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le are mock implementations
|
In future we might do something about this in rspec-support for improving the detection of Rubies supporting such tweaks but for now I see no harm in merging this. |
|
Thanks! |
|
A conservative check for this would be to only try GC.enable/GC.disable if |
|
Thanks for all of those patch for TruffleRuby |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…r-truffleruby Disable memory leak spec for TruffleRuby
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GC.disableandGC.enableare mock implementations in TruffleRuby which causes this spec to fail.