Emit a warning for around(:context)

[pirj]

fixes #2486

related to rspec/rspec#6

[benoittgt]

LGTM

[JonRowe]

👍

[shepmaster]

One thing confusing about this warning is that it points to something that isn't literally around(:context):

WARNING: `around(:context)` hooks are not supported and behave like `around(:example). Called from ...spec/controllers/clients_controller_spec.rb:31:in `block (2 levels) in <top (required)>'.

% sed -n 31p spec/controllers/clients_controller_spec.rb
    around(:all) do |example|

[JonRowe]

As :all is an alias for :context, it is literally the same, theres no way for us to know other than making the warning more verbose, e.g:

around(:context) (or an alias such as :all).

[shepmaster]

Sure, I'm not saying that it's incorrect, just confusing.

[pirj]

We can probably move this warning deeper, to scope_and_options_from where we still have the original scope argument before normalization.

@shepmaster Would you want to tackle that?

[shepmaster]

Would you want to tackle that?

Thank you for the offer, but it seems unlikely I'll have the time for it 😿.

We only had one case of this warning so my specific pain has passed. I mostly thought to post this in case other people have the same pain, or if y'all start getting a lot of reports.