Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Update rake with_clean_environment spec to verify keys ignoring order #2720

Merged

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 10, 2020

This allows verifying the keys are correct but ignores the order. It allows testing JVM implementations that rely on System.getenv() for environment variables.

@bjfish bjfish force-pushed the update-rake-task-spec-with-clean-environment branch from 4bcd490 to 569a1e9 Compare April 11, 2020 13:16
@benoittgt
Copy link
Member

Few errors with aruba's dependency childprocess and old Ruby 2 versions. I reran the CI for this two builds and it passed.

@JonRowe JonRowe merged commit 30cfad0 into rspec:master Apr 12, 2020
@bjfish bjfish deleted the update-rake-task-spec-with-clean-environment branch April 13, 2020 13:45
MatheusRich pushed a commit to MatheusRich/rspec-core that referenced this pull request Oct 30, 2020
…clean-environment

Update rake with_clean_environment spec to verify keys ignoring order
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants