Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Fix documentation surrounding hook order #2735

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix documentation surrounding hook order #2735

merged 1 commit into from
Jun 11, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jun 4, 2020

Fixes #2729

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JonRowe
Copy link
Member Author

JonRowe commented Jun 10, 2020

@pirj please re-review, I've clarified example group vs scope giving the er... context of the docs 😂

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
The wording is hard, but you've hit the nail on the head here.

@JonRowe JonRowe merged commit 5685ccf into master Jun 11, 2020
@JonRowe JonRowe deleted the fix-hook-docs branch June 11, 2020 07:39
JonRowe added a commit that referenced this pull request Jun 29, 2020
Fix documentation surrounding hook order
MatheusRich pushed a commit to MatheusRich/rspec-core that referenced this pull request Oct 30, 2020
Fix documentation surrounding hook order
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
Fix documentation surrounding hook order

---
This commit was imported from rspec/rspec-core@8bd81ee.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrary to documentation,around hooks runs before before
2 participants