Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Updates from rspec-dev (2020-11-16) #2782

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Nov 16, 2020

These are some updates, generated from rspec-dev's rake tasks.

- '*-dev'
pull_request:
branches:
- '*'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirj @benoittgt this seems to work for pull requests at least with just one build, will need to push to a branch (probably maintenance to cherry-pick the config) to test it still builds pushes.

@JonRowe JonRowe force-pushed the update-ci-build-scripts-2020-11-16-for-main branch from 8a71af9 to 002d511 Compare November 16, 2020 22:10
- uses: actions/cache@v2
with:
path: ../bundle
key: ${{ runner.os }}-${{ matrix.ruby }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being removed because it doesn't work, but bundle-cache: true does

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

I'll also pull all recent changes to 4-0-dev

@JonRowe JonRowe merged commit bb97af8 into main Nov 17, 2020
@JonRowe JonRowe deleted the update-ci-build-scripts-2020-11-16-for-main branch November 17, 2020 06:20
@JonRowe
Copy link
Member Author

JonRowe commented Nov 17, 2020

I'll also pull all recent changes to 4-0-dev

FYI I've rebased all the 4-0-dev branches and set them up so there builds pass.

@pirj
Copy link
Member

pirj commented Nov 17, 2020

Thanks! 🙌

JonRowe added a commit that referenced this pull request Dec 27, 2020
…6-for-main

Updates from rspec-dev (2020-11-16)
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…build-scripts-2020-11-16-for-main

Updates from rspec-dev (2020-11-16)

---
This commit was imported from rspec/rspec-core@bb97af8.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…build-scripts-2020-11-16-for-main

Updates from rspec-dev (2020-11-16)

---
This commit was imported from rspec/rspec-core@3313fc0.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants