Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Enable warning support explicitly #2811

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 22, 2020

When enabling RSpecs warning mode, it should include the keyword argument deprecations from Ruby.
See #2809 for the background for this.

(Fixes #2809)

@benoittgt
Copy link
Member

@eregon are you ok with this change?

Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency 🙌

@JonRowe JonRowe force-pushed the enable-deprecation-support-explicitly branch from 18cb2a2 to 77b4a96 Compare December 22, 2020 17:49
Copy link
Contributor

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the quick fix!

@JonRowe JonRowe merged commit addcfb4 into main Dec 22, 2020
@JonRowe JonRowe deleted the enable-deprecation-support-explicitly branch December 22, 2020 21:26
JonRowe added a commit that referenced this pull request Dec 22, 2020
JonRowe added a commit that referenced this pull request Dec 22, 2020
JonRowe added a commit that referenced this pull request Dec 22, 2020
JonRowe added a commit that referenced this pull request Dec 22, 2020
JonRowe added a commit that referenced this pull request Dec 27, 2020
JonRowe added a commit that referenced this pull request Dec 27, 2020
JonRowe added a commit that referenced this pull request Dec 27, 2020
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…recation-support-explicitly

Enable warning support explicitly

---
This commit was imported from rspec/rspec-core@addcfb4.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…recation-support-explicitly

Enable warning support explicitly

---
This commit was imported from rspec/rspec-core@b62f1d2.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…recation-support-explicitly

Enable warning support explicitly

---
This commit was imported from rspec/rspec-core@b1f151e.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
pirj pushed a commit that referenced this pull request Oct 25, 2022
JonRowe added a commit that referenced this pull request Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rspec -w is not the same as ruby -w and does not show deprecation warnings
4 participants