This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Reset patch-level dependency to 0 #2850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-zero patch level in the pessimistic version constraint means you can't install the next minor version until its patch level reaches the constraint patch level.
JonRowe
approved these changes
Jan 15, 2021
|
Apologies, this wasn't back ported from For reference for others, this only affected installs via git specifically on the |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
Reset patch-level dependency to 0 --- This commit was imported from rspec/rspec-core@6543181.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble upgrading rspec to 3.10, and it seems like this change (acc718e) means no one can upgrade to 3.10 until rspec-support gets to 3.10.3.Maybe I'm missing some new idiosyncrasy in the dependency relationships for rspec, but setting this back to 0 allows upgrade to 3.10 since any patch level will be accepted.Edit: Turns out my rspec-rails dependency blocks getting up to 3.10 on this gem, so I stumbled backwards into this. Thanks for the clarifying comment, @JonRowe !