This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Implement RSpec.current_scope (in 4.0, to switch rspec-rails to it painlessly)
#2910
+138
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My reasoning is: rspec-rails needs to do the following condition: `if RSpec.current_scope == :before_context_hook` test_prof needs to do the following condition: `if RSpec.current_scope == :before_context_hook` amd my little helper needs the following `unless [:before_example_hook, :example].include?(RSpec.current_scope)`
pirj
changed the title
rspec-rails to it painlessly)
1 task
|
Is this PR needed? Normally we just cherry-pick the merge commits across? |
|
Cherry-picking is an option, and surely a simpler one. |
|
Cherry-picked #2895 to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reproduction of #2895 on 4-0-dev branch.
The plan:
rspec-core4.0.0.pre (this PR)rspec-rails's main branch to useRSpec.current_scope(main depends on 4.0.0.pre ofrspec-*), Use RSpec.current_scope rspec-rails#2511currently_executing_a_context_hook?andself.inspecthack #2895 (deprecatescurrently_executing_a_context_hook?and introducesRSpec.current_scope) torspec-core3.10-maintenance (will become part of 3.11/3.99)currently_executing_a_context_hook?from 4-0-dev