This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Add support for bright colors #2913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
suggested changes
Sep 21, 2021
There was a problem hiding this comment.
I'm happy to add bold colour combinations, but we need a few tweaks to get this across the line. I'd also like the extra colour combinations mentioned in features/formatters/configurable_colors.feature, and prehaps adding a couple of extra scenarios demonstrating the use of a custom combination?
githubuseracct
force-pushed
the
main
branch
from
3e69b7a to
c4cd13c
Compare
githubuseracct
force-pushed
the
main
branch
from
c4cd13c to
74f3014
Compare
I added a new feature file. I don't know a thing about cucumber and indeed something isn't finished. I'd be happy to poke at it some more, but I'd need to get over the learning curve first. |
|
Merged in #2914 |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 12, 2021
This commit was imported from rspec/rspec-core@053fcfe.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
This commit was imported from rspec/rspec-core@e281de2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.