This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix cucumber issues blocking ruby-head #2937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change looses the cucumber version restriction, allowing recent cucumbers. It also handles the change in the 'not' syntax for tags, allowing it to run on a wide range of Ruby versions Don't use Fixnum in the described_class test. Add an 'outer' test.
|
I'm seeing failures on Ruby 2.3 (Windows) and JRuby 1.7, but those appear to be pre-existing problems. There's a doc check failure, but rspec and cucumber run cleanly on ruby-head with these changes. |
|
The doc check failure is an issue in yard. There is a fix - lsegal/yard@7dca12c - but it's not in a released gem yet. |
|
@petergoldstein thanks so much for this, it's been merged in #2950 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets CI to green against ruby-head. It does so by:
cc: @JonRowe