This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Allow custom ordering on cli #3025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
allow-custom-ordering-on-cli
branch
from
2e7a3a3 to
c488739
Compare
JonRowe
force-pushed
the
allow-custom-ordering-on-cli
branch
from
c488739 to
d3efa21
Compare
benoittgt
approved these changes
Mar 31, 2023
|
@JonRowe Do you think this change could be the reason for |
|
Got it. It's from this line: because "default" is not an accepted order. |
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Apr 14, 2023
"default" is not an allowed value, and started failing after rspec/rspec-core#3025
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Apr 14, 2023
"default" is not an allowed value, and started failing after rspec/rspec-core#3025
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Apr 14, 2023
"default" is not an allowed value, and started failing after rspec/rspec-core#3025
|
Released in 3.13.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docs for ordering with some specific examples, adds the ability to defer loading an ordering strategy which in turn enables custom ordering via the cli.