Only enable rubygems for bundle install #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
disable_rubygems
branch
from
c335da2 to
06705ef
Compare
|
LGTM assuming it works in the builds. |
myronmarston
added a commit
that referenced
this pull request
Jan 6, 2016
Only enable rubygems for bundle install
|
The builds all passed, so merging this. Thanks, @JonRowe! |
|
I just opened PRs against 3-4-maintenance as well as we'll need this there for any builds against that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off rubygems in our normal build process, but use it during
bundle installfor things likenokogiriwhich expect it to be available during the build process. As suggested by @myronmarston as an improvement to @yujinakayama's PR.rspec/rspec-core#2152
rspec/rspec-mocks#1051
rspec/rspec-expectations#885
rspec/rspec-rails#1521
rspec/rspec-support#263