Build updates #156
Merged
Build updates #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,8 @@ cache: | |||
| before_install: | |||
| - "script/clone_all_rspec_repos" | |||
| # Note this doesn't work on JRUBY 2.0.0 mode so we don't do it, the excluded versions are broken on Ruby 2.3 | |||
| - if [ "jruby" != "$TRAVIS_RUBY_VERSION" ]; then gem install bundler --version "!= 1.12.0, != 1.12.1"; fi | |||
| - if [ "jruby" != "$TRAVIS_RUBY_VERSION" ]; then gem install bundler --version "!= 1.12.0, != 1.12.1, != 1.12.2, != 1.12.3"; fi | |||
| install: if [ "jruby" != "$TRAVIS_RUBY_VERSION" ]; then bundle _1.11.2_ install --binstubs --standalone --without documentation --path ../bundle; else bundle install --binstubs --standalone --without documentation --path ../bundle; fi | |||
There was a problem hiding this comment.
Honestly, it seems simpler to just install 1.11 (and specify just that version) util there's a new release that works.
There was a problem hiding this comment.
Also, instead of putting the whole bundle command, you can just alias bundle to bundle _1.11.2_. See 35ac13f for an example.
There was a problem hiding this comment.
Updated, 1.12.4 will fix this anyway :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it seems Bundler 1.12 is still broken for us, I expect us to be able to remove the version select at some point, but currently we can't install
jsonon 2.3.1 on travis, and it also seems to break appveyor with warnings.