Update base rubocop config for new version, disabling most of the new things. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviershay
commented
Jan 2, 2018
| @@ -2,7 +2,7 @@ | |||
| # can customize by inheriting this file and overriding particular settings. | |||
|
|
|||
| AccessModifierIndentation: | |||
| EnforcedStyle: outdent | |||
There was a problem hiding this comment.
we weren't consistently respecting this in repos (particularly with module_function)
| @@ -47,9 +47,6 @@ DoubleNegation: | |||
| EachWithObject: | |||
| Enabled: false | |||
|
|
|||
| Encoding: | |||
| EnforcedStyle: when_needed | |||
There was a problem hiding this comment.
No longer respected by rubocop.
| @@ -95,9 +92,6 @@ PredicateName: | |||
| Proc: | |||
| Enabled: false | |||
|
|
|||
| RedundantReturn: | |||
| AllowMultipleReturnValues: true | |||
There was a problem hiding this comment.
Possibly could have figured out a way to keep this, but just disabled it instead.
Soonray1818
approved these changes
Jan 4, 2018
xaviershay
force-pushed
the
upgrade-rubocop
branch
from
5933272 to
40437e4
Compare
|
I think we should merge this PR to try to be more synched to other rspec repos. |
|
I agree :) |
|
@xaviershay Have you opened the PRs for the repos based on this? |
|
|
Yes, iirc they've been merged already. (Sorry traveling atm)
On Sat, Mar 3, 2018, at 11:54 PM, Jon Rowe wrote:
@xaviershay[1] Have you opened the PRs for the repos based on this?> — You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[2], or mute the thread[3].>
|
|
Thanks @xaviershay wasn't sure if they had all been done to the same level, seems its just rspec-rails with differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I disabled all the new layout and style cops, but tried to keep the lint/perf/security ones.
Didn't bother with any kind of sorting/order, couldn't come up with a quick way to do and figured it wouldn't be that valuable.