Update rake to current #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by ``` /path/to/rake-11.0.1/lib/rake/ext/fixnum.rb:4: warning: constant ::Fixnum is deprecated ``` when running `bundle exec rake git:pull`.
|
Thanks for this, this needs a gate condition to check we're running a Ruby version that supports Rake 12, (given RSpec runs on a variety of Rubies and we have to do dev on a variety of Rubies) |
|
This requirement has the same ruby version restrictions as the previous one, it seems $ gem specification --ruby --remote rake -v 11.0.1 | grep required_ruby_version
s.required_ruby_version = Gem::Requirement.new(">= 1.9.3".freeze)
$ gem specification --ruby --remote rake -v 12.0.0 | grep required_ruby_version
s.required_ruby_version = Gem::Requirement.new(">= 1.9.3".freeze)(Used 11.0.1 in the experiment because 11.0.0 was yanked, apparently). |
|
Fair enough, I suppose it is only our dev tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by
when running
bundle exec rake git:pull.