Skip to content

Add sponsor file #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Add sponsor file #223

merged 2 commits into from
Dec 6, 2019

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Nov 27, 2019

The intent of this pr is to add the sponsor file to all our controller repos with our open collective details as well as my own sponsor account (shameless plug etc) but does so via our common files, I think this should still work with our markdown files.

@JonRowe
Copy link
Member Author

JonRowe commented Nov 27, 2019

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@JonRowe JonRowe force-pushed the add-sponsor-file branch 2 times, most recently from 04d4a69 to eec1752 Compare December 5, 2019 21:22
@JonRowe
Copy link
Member Author

JonRowe commented Dec 5, 2019

Changed to ensure all common plaintext files were found (e.g. I fixed the glob) and correctly commented in yml files.

Care to re-review @pirj ?

See:
rspec/rspec-core#2672
rspec/rspec-expectations#1145
rspec/rspec-mocks#1301
rspec/rspec-rails#2213
rspec/rspec-rails#2221
rspec/rspec-support#386
rspec/rspec-support#387 (first one merged to early)

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just as the produced results 👍

@JonRowe JonRowe merged commit 5ce9b94 into master Dec 6, 2019
@JonRowe JonRowe deleted the add-sponsor-file branch December 6, 2019 07:55
@JonRowe JonRowe mentioned this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants