Skip to content

Update Ruby versions adding 2.7.0 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2019
Merged

Update Ruby versions adding 2.7.0 #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
284f25a
Update Ruby versions adding 2.7.0
JonRowe Dec 26, 2019
30859b5
Prevent rubydoc check running on 2.7.0
JonRowe Dec 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions travis/.travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ rvm:
- 2.1
- 2.2.10
- 2.3.8
- 2.4.6
- 2.5.5
- 2.6.2
- 2.4.9
- 2.5.7
- 2.6.5
- 2.7.0
- ruby-head
- ree
- rbx-3
Expand Down
18 changes: 17 additions & 1 deletion travis/script/predicate_functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ function is_ruby_23_plus {
fi
}

function is_mri_27 {
if is_mri; then
if ruby -e "exit(RUBY_VERSION.to_f == 2.7)"; then
return 0
else
return 1
fi
else
return 1
fi
}

function rspec_rails_compatible {
if is_ruby_23_plus; then
return 0
Expand All @@ -86,7 +98,11 @@ function additional_specs_available {
function documentation_enforced {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirj @benoittgt we need to figure out why yard isn't running on 2.7.0, but suggest we merge this to indicate the state of our other builds then figure out how to restore this check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it 👍

if [ -x ./bin/yard ]; then
if is_mri_2plus; then
return 0
if is_mri_27; then
return 1
else
return 0
fi
else
return 1
fi
Expand Down