Revert "Prevent rubydoc check running on 2.7.0" #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you'll need to pair this with updates for yard to 0.9.21, want to tackle some prs on the repos? |
|
Yes. :) |
Yard 0.9.21 support Ruby 2.7 now. https://github.com/lsegal/yard/releases/tag/v0.9.21 This reverts commit 30859b5.
benoittgt
force-pushed
the
re-enable-yard-check
branch
from
4db69d4 to
3a8a6a0
Compare
|
Sorry. I think we should re-enable yard doc check on 2.7. |
|
As long as we've got all the repos on 0.9.21 and above this should be fine right? Core is on 0.9.24 |
|
Yes I think |
|
Sorry, I lost the track - is this one still actual? |
|
Oups yes! |
This was referenced Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yard 0.9.21 support Ruby 2.7 now.
https://github.com/lsegal/yard/releases/tag/v0.9.21
This reverts commit 30859b5.
Close: #232