Update scripts to run compat specs against Rails 6 #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Jan 23, 2020
| @@ -2,7 +2,7 @@ | |||
| set -e | |||
| source script/functions.sh | |||
|
|
|||
| if is_ruby_23_plus; then | |||
| if is_ruby_25_plus; then | |||
JonRowe
reviewed
Jan 23, 2020
JonRowe
requested changes
Jan 23, 2020
pirj
force-pushed
the
update-scripts-to-run-rails-6-compat-specs
branch
from
b7b71be to
114ff33
Compare
JonRowe
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
rspec-railscompat specs were run against Rails 5, and some of them, specifically ActionCable ones, are only present and run for Rails 6.This change makes sure
rspec-core/rspec-mocks/rspec-expectations/rspec-supportchanges don't breakrspec-rails's newer features.Changes from
ruby_23_plustoruby_25_plusis required since Rails 6 requires Ruby 2.5+ (compared to 2.2.2+ for Rails 5).rspec/rspec-support#398
rspec/rspec-core#2691
rspec/rspec-expectations#1159
rspec/rspec-mocks#1314
rspec/rspec-rails#2269- not neededRelated update to use Rails 6 when running specs by default rspec/rspec-rails#2267 (merged)
Proof that it works as expected:
rspec/rspec-expectations#1157
https://travis-ci.org/rspec/rspec-expectations/builds/641000927