Skip to content

Follow up for #254 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2020
Merged

Follow up for #254 #255

merged 2 commits into from
Nov 17, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Nov 16, 2020

Removes unused caching code, and correct run strategy for branches

pirj
pirj approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked flawlessly on those update prs, I don't see why wouldn't it work for the rest 👍

@JonRowe JonRowe merged commit 2b53466 into main Nov 17, 2020
@JonRowe JonRowe deleted the update-ci branch November 17, 2020 06:19
@JonRowe
Copy link
Member Author

JonRowe commented Nov 17, 2020 •
edited
Loading

Worked flawlessly on those update prs, I don't see why wouldn't it work for the rest 👍

I tested, pushes to dev + main branches work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonRowe @pirj