Skip to content

Drop old rubies #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2020
Merged

Drop old rubies #261

merged 4 commits into from
Dec 8, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 8, 2020

/cc @pirj

pirj
pirj requested changes Dec 8, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, this PR is set against main, and it removes Ruby < 2.3, is this correct?

PS There's a 4-0-dev branch here in rspec-dev as well.

@JonRowe JonRowe changed the base branch from main to 4-0-dev December 8, 2020 10:30
@JonRowe JonRowe merged commit 19d59e0 into 4-0-dev Dec 8, 2020
@JonRowe JonRowe deleted the drop-just-old-rubies branch December 8, 2020 10:30
@JonRowe
Copy link
Member Author

JonRowe commented Dec 8, 2020

Thanks for spotting I hadn't changed the target, it was based off 4-0-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonRowe @pirj