Skip to content

Fix ruby head #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ def force_update(branch, custom_pr_comment, skip_confirmation=false, opts={})
end

def update_files_in_repos(purpose, suffix='', opts={})
suffix = [BASE_BRANCH, ENV['BRANCH_SUFFIX']].join('-')
suffix = [BASE_BRANCH, ENV['BRANCH_SUFFIX']].compact.join('-')
branch_name = "update-#{purpose.gsub ' ', '-'}-#{ENV.fetch('BRANCH_DATE',Date.today.iso8601)}-for-#{suffix}"

each_project_with_common_build(opts) do |proj|
Expand Down
4 changes: 3 additions & 1 deletion ci/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@ jobs:
- 2.3
- 2.2
- 2.1.9
- ruby-head
env:
-
DIFF_LCS_VERSION: "> 1.4.3"
include:
- ruby: ruby-head
env:
RUBY_HEAD: true
- ruby: jruby-9.2.13.0
env:
JRUBY_OPTS: "--dev"
Expand Down
22 changes: 22 additions & 0 deletions ci/script/predicate_functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,28 @@ function is_mri {
fi;
}

function is_ruby_head {
# This checks for the presence of our CI's ruby-head env variable
if [ -z ${RUBY_HEAD+x} ]; then
return 1
else
return 0
fi;
}

function supports_cross_build_checks {
if is_mri; then
# We don't run cross build checks on ruby-head
if is_ruby_head; then
return 1
else
return 0
fi
else
return 1
fi
}

function is_jruby {
if ruby -e "exit(defined?(RUBY_PLATFORM) && RUBY_PLATFORM == 'java')"; then
# RUBY_ENGINE only returns 'ruby' on MRI.
Expand Down
2 changes: 1 addition & 1 deletion ci/script/run_build
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if style_and_lint_enforced; then
fold "rubocop" check_style_and_lint
fi

if is_mri; then
if supports_cross_build_checks; then
fold "one-by-one specs" run_specs_one_by_one
run_all_spec_suites
else
Expand Down