Updates to script for 2-14-maintenance #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elsif input =~ /^r(?:ename)? (.*)$/ | ||
| branch_name = $1 | ||
| end | ||
| end |
There was a problem hiding this comment.
This looks pretty useful but the rename thing confused me a bit -- I assumed it was renaming the branch that was already there, rather than using a different name for the branch you are creating.
There was a problem hiding this comment.
Note, this diff doesn't show that due to @github "feature", this diff is outdated it just doesn't admit it.
|
LGTM |
…h, also handles conflict with existing branches
JonRowe
added a commit
that referenced
this pull request
Feb 10, 2014
Updates to script for 2-14-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the updates I should have pushed earlier, sorry @myronmarston, I
basically extracted the "should we run support" stuff into a function so that
2-14 could be added to the list of builds not to run it on.
I also added to the Rakefile because partly aborted updates werent cleaning up
after themselves so this deletes the branch or renames the branch as desired.