This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Backport strict predicate fix #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
1) RSpec::Mocks::Constant.original for a previously defined unstubbed constant indicates it was previously defined
Failure/Error: it("indicates it was previously defined") { expect(const).to be_previously_defined }
expected `#<RSpec::Mocks::Constant TestClass::M>.previously_defined?` to return true, got [:m, "TestClass::M"]
# ./spec/rspec/mocks/mutate_const_spec.rb:446:in `block (4 levels) in <module:Mocks>'
```
benoittgt
approved these changes
Jan 15, 2021
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…-strict-predicate-fix Backport strict predicate fix --- This commit was imported from rspec/rspec-mocks@65e97d1.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…-strict-predicate-fix Backport strict predicate fix --- This commit was imported from rspec/rspec-mocks@5662509.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was initialy made in
4-0-devbut is arguably a bug fix so can be backported to 3.10