Check for puma and capybara when defining system tests (#1893)

* Check for puma and capybara when defining system tests

Rather than skipping the definition altogether define a fake module that
warns about the dependencies.

* If we can't load system_test_case for some reason we cant run system tests

As per @mockdeep's conversation in #1889 other dependencies might not
allow us to even load system_test_case so we fallback to our original
strategy for now.

Author: JonRowe

lib/rspec/rails/configuration.rb

@@ -49,17 +49,7 @@ def self.add_test_type_configurations(config)
       config.include RSpec::Rails::ViewExampleGroup,       :type => :view
       config.include RSpec::Rails::FeatureExampleGroup,    :type => :feature
       config.include RSpec::Rails::Matchers
-
-      if ActionPack::VERSION::STRING >= "5.1"
-        begin
-          require 'puma'
-          require 'capybara'
-          config.include RSpec::Rails::SystemExampleGroup, :type => :system
-        # rubocop:disable Lint/HandleExceptions
-        rescue LoadError
-          # rubocop:enable Lint/HandleExceptions
-        end
-      end
+      config.include RSpec::Rails::SystemExampleGroup, :type => :system
     end
 
     # @private

lib/rspec/rails/example.rb

@@ -8,13 +8,4 @@
 require 'rspec/rails/example/model_example_group'
 require 'rspec/rails/example/job_example_group'
 require 'rspec/rails/example/feature_example_group'
-if ActionPack::VERSION::STRING >= "5.1"
-  begin
-    require 'puma'
-    require 'capybara'
-    require 'rspec/rails/example/system_example_group'
-  # rubocop:disable Lint/HandleExceptions
-  rescue LoadError
-    # rubocop:enable Lint/HandleExceptions
-  end
-end
+require 'rspec/rails/example/system_example_group'

lib/rspec/rails/example/system_example_group.rb

@@ -1,5 +1,33 @@
-if ActionPack::VERSION::STRING >= "5.1"
-  require 'action_dispatch/system_test_case'
+can_load_system_tests = false
+begin
+  require 'puma'
+  require 'capybara'
+  if ActionPack::VERSION::STRING >= "5.1"
+    require 'action_dispatch/system_test_case'
+    can_load_system_tests = true
+  end
+# rubocop:disable Lint/HandleExceptions
+rescue LoadError
+  # rubocop:enable Lint/HandleExceptions
+end
+
+if !can_load_system_tests
+  module RSpec
+    module Rails
+      module SystemExampleGroup
+        extend ActiveSupport::Concern
+
+        included do
+          abort """
+            System test integration requires Rails >= 5.1 and has a hard
+            dependency on `puma` and `capybara`, please add these to your
+            Gemfile before attempting to use system tests.
+          """
+        end
+      end
+    end
+  end
+else
   module RSpec
     module Rails
       # @api public

spec/rspec/rails/example/system_example_group_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 module RSpec::Rails
-  if defined?(SystemExampleGroup)
+  if ActionPack::VERSION::STRING >= "5.1"
     RSpec.describe SystemExampleGroup do
       it_behaves_like "an rspec-rails example group mixin", :system,
         './spec/system/', '.\\spec\\system\\'