Check for puma and capybara when defining system tests #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than skipping the definition altogether define a fake module that warns about the dependencies.
JonRowe
force-pushed
the
fix_system_tests_when_not_loaded
branch
from
463af44 to
67d7b97
Compare
This was referenced Oct 23, 2017
|
@JonRowe Just gave this a spin in a Rails app that doesn't have/need Capybara, and it didn't have any issues, nor did I see any warning (which is good, because I don't have any system tests). |
|
Thanks so much @pat! |
|
@myronmarston can you give me a quick sanity check in lieu of @samphippen (who's in hospital right now), as I'd like to release it to help rails devs |
JonRowe
added a commit
that referenced
this pull request
Nov 20, 2017
* Check for puma and capybara when defining system tests Rather than skipping the definition altogether define a fake module that warns about the dependencies. * If we can't load system_test_case for some reason we cant run system tests As per @mockdeep's conversation in #1889 other dependencies might not allow us to even load system_test_case so we fallback to our original strategy for now.
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
* Check for puma and capybara when defining system tests Rather than skipping the definition altogether define a fake module that warns about the dependencies. * If we can't load system_test_case for some reason we cant run system tests As per @mockdeep's conversation in rspec#1889 other dependencies might not allow us to even load system_test_case so we fallback to our original strategy for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than skipping the definition altogether define a fake module that
warns about the dependencies.