Merge pull request #1955 from shanecav84/patch-1

Substitute quotes with underscores for method name

Author: JonRowe

lib/rspec/rails/example/system_example_group.rb

@@ -11,6 +11,9 @@ module SystemExampleGroup
       include ActionDispatch::Assertions
       include ActionController::TemplateAssertions
 
+      # Special characters to translate into underscores for #method_name
+      CHARS_TO_TRANSLATE = ['/', '.', ':', ',', "'", '"', " "].freeze
+
       # @private
       module BlowAwayAfterTeardownHook
         # @private
@@ -35,7 +38,7 @@ def method_name
           self.class.name.underscore,
           RSpec.current_example.description.underscore,
           rand(1000)
-        ].join("_").gsub(/[\/\.:, ]/, "_")
+        ].join("_").tr(CHARS_TO_TRANSLATE.join, "_")
       end
 
       # Delegates to `Rails.application`.

spec/rspec/rails/example/system_example_group_spec.rb

@@ -4,6 +4,20 @@ module RSpec::Rails
     RSpec.describe SystemExampleGroup do
       it_behaves_like "an rspec-rails example group mixin", :system,
         './spec/system/', '.\\spec\\system\\'
+
+      describe '#method_name' do
+        it 'converts special characters to underscores' do
+          group = RSpec::Core::ExampleGroup.describe ActionPack do
+            include SystemExampleGroup
+          end
+          SystemExampleGroup::CHARS_TO_TRANSLATE.each do |char|
+            example = group.new
+            example_class_mock = double('name' => "method#{char}name")
+            allow(example).to receive(:class).and_return(example_class_mock)
+            expect(example.send(:method_name)).to start_with('method_name')
+          end
+        end
+      end
     end
   end
 end