Substitute quotes with underscores for method name #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails' SystemTestCase uses `method_name` to generate a filename for a screenshot, which is output along with the failure message. The filename for examples with single or double quotation marks retain the marks, making it tedious to copy-and-past the generated filename then manually escape it to use in a shell command.
JonRowe
requested changes
Feb 13, 2018
|
Sounds good. I can get that in the next few days.
|
|
What do you think about just replacing the regex with |
|
I'd rather we only remove characters that would otherwise cause problems. |
|
Spec is up. I changed the |
JonRowe
approved these changes
Feb 16, 2018
|
Thanks, I've kicked the build to see if it'll go green and will assess it if it fails again. |
JonRowe
added a commit
that referenced
this pull request
Feb 16, 2018
Substitute quotes with underscores for method name
|
Merged, thanks |
benoittgt
pushed a commit
to benoittgt/rspec-rails
that referenced
this pull request
Mar 4, 2018
[skip ci]
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails' SystemTestCase uses
method_nameto generate a filename for a screenshot, which is output along with the failure message. The filename for examples with single or double quotation marks retain the marks, making it tedious to copy-and-past the generated filename then manually escape it to use in a shell command.