Skip to content

Add a script to test a rails app being made a-fresh. #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fables-tales
Copy link
Member

No description provided.

@fables-tales
Copy link
Member Author

This failed for me on master, and passed on the branch I created, so I think it's testing the behaviour we want.

@fables-tales
Copy link
Member Author

This build seems to be stuck in travis's queue, is that normal?

@myronmarston
Copy link
Member

I thought our build already did something like this. Does it not?

@fables-tales
Copy link
Member Author

It does, but something about how it gets loaded means that rspec-support has already been required by the time we get to that line of code. This is completely outside of any RSpec launched context and thusly seems to actually detect on the bug.

@myronmarston
Copy link
Member

Can we change the existing part of the build to use this then? Seems unnecessary to do this twice in two different ways as part of 1 build.

@cupakromer
Copy link
Member

I really appreciate all the help you've done with this @samphippen. I agree with Myron that we should find a way to integrate this with the existing process / fix the existing process. When the build runs, it is supposed to check these things.

There is a Rake task called smoke. I believe this task was intended to catch exactly this, as well as, a very basic app's specs generated through the generators. I'd love to get that properly fixed.

@fables-tales
Copy link
Member Author

Gonna close this in favour of fixing the existing smoke tooling. @cupakromer and I are going to take a look at this over at Ruby Nation.

@cupakromer cupakromer mentioned this pull request Jun 13, 2014
@cupakromer cupakromer deleted the fix-rails-for-3.0.0 branch December 28, 2014 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants