Add note about infer_spec_type_from_file_location!
#1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can you add a link to the relish doc for this? |
|
Which one specifically? |
|
Um. Ok, we're missing some docs. You can link to directory structure for now: https://www.relishapp.com/rspec/rspec-rails/v/3-0/docs/directory-structure |
|
Thanks for adding this to the readme! |
|
The reason I noticed was someone pinging me on twitter about, me directing them to the docs, then going oh shit, no docs :P |
| > File-type inference disabled by default | ||
|
|
||
| Previously we automatically inferred spec type from a file location, this | ||
| was a suprising behaviour for new users and undesriable for some veteran users |
There was a problem hiding this comment.
Typo "undesriable" should be "undesirable"
|
LGTM after fixing the typo. Feel free to merge when ready, then backport to the |
Somehow this isn't mentioned already, and it really should be given that it confuses so many people... [skip ci]
JonRowe
added a commit
that referenced
this pull request
Jun 13, 2014
Add note about `infer_spec_type_from_file_location!`
JonRowe
added a commit
that referenced
this pull request
Jun 13, 2014
Add note about `infer_spec_type_from_file_location!`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow this isn't mentioned already, and it really should be given that it confuses so many people...