manually tag request specs to aid users #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @cupakromer |
|
Thanks for starting this. Looks like we should do this for all the specs. |
|
Also, I think the other issue was pointing out that there's no line about From the controller specs:
There's no equivalent line in the request specs feature. |
…reference for it over inferring location
JonRowe
force-pushed
the
update_request_docs
branch
from
354e99b to
eabf9bc
Compare
|
@cupakromer I've updated this to tag all examples and tweak the wording about it for all the different types |
|
Awesome! Thanks for tackling this one. ❤️ LGTM. It's a bit late so I'm not going to merge as my eye are blurry. But if it looks good to you 👍 to merge away. |
JonRowe
added a commit
that referenced
this pull request
Oct 17, 2014
manually tag request specs to aid users
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189