If a view example's description contains no path elements, then do not attempt to load a helper based on the example description.

[tinynumbers]

This odd edge case was encountered in a Rails project where a "presenter" type class was being spec'd as a ViewExampleGroup (via the type: :view). Since the example group for this class has a description with no path element, the ViewExampleGroup attempt to auto-load related helpers was trying to find (and load) a helper named Helper.

The actual issue was discovered when someone introduced (elsewhere within the specs) a class named Helper. Prior to this, the presenter example group had not caused problems since there was no Helper module or class to load, but once this new class was introduced, we started seeing an exception:

.../actionpack-3.2.21/lib/abstract_controller/helpers.rb:153:in `include': wrong argument type Class (expected Module) (TypeError)
  from .../actionpack-3.2.21/lib/abstract_controller/helpers.rb:153:in `block in add_template_helper'
  from .../actionpack-3.2.21/lib/abstract_controller/helpers.rb:153:in `module_eval'
  from .../actionpack-3.2.21/lib/abstract_controller/helpers.rb:153:in `add_template_helper'
  from .../actionpack-3.2.21/lib/abstract_controller/helpers.rb:96:in `block in helper'
  from .../actionpack-3.2.21/lib/abstract_controller/helpers.rb:95:in `each'
  from .../actionpack-3.2.21/lib/abstract_controller/helpers.rb:95:in `helper'
  from .../rspec-rails-2.14.2/lib/rspec/rails/example/view_example_group.rb:150:in `block in <module:ViewExampleGroup>'

Previously-failing example and fix provided here.

[cupakromer]

Are you rendering a view in these specs?

While I understand the root issue, I'm not sure the view spec is intended for this use case. It sounds like you are just testing a "plain old Ruby object" which happens to use parts of Rails.

[tinynumbers]

@cupakromer You're right, this is a bit outside the intended use of view specs, but the PORO-ish class that is being tested actually is directly responsible for rendering (via e.g. content_tag, concat, etc), so this was setup as a view spec in order to have access to the view, params, etc that are provided by to views (and view specs).

Not at all disagreeing that the design of the test that surfaced this issue (and the object being tested) needs some reconsideration, but at the same time, what I'm pointing out here is still a (potential) bug. For example, what if you want to test a view template that sits at the root of your app/views folder?

[tinynumbers]

I've created a minimal test application illustrating the requirements for reproducing this bug:

https://github.com/tinynumbers/rspec_pr_1289

The repo's Readme provides more details.

[tinynumbers]

Any chance of getting this merged?

[cupakromer]

This is good. Thanks for the contribution @tinynumbers ❤️

Very sorry for taking so incredibly long to merge.

[tinynumbers]

Thanks @cupakromer!