Fix action mailer preview path setup. #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupakromer
force-pushed
the
update-action-mailer-railtie
branch
from
1e4b4df to
74b95f2
Compare
mxie
added a commit
to thoughtbot/clearance
that referenced
this pull request
Mar 2, 2015
ActionMailer is prematurely loaded in rspec-rails, causing some issues when reading its config. There's a PR out for it: rspec/rspec-rails#1327. It was also recommended in rspec/rspec-rails#1313 that we not refer to the app's config in initializers, but to refer to ActionMailer itself to set the config.
This removes the unnecessary warning about a preview path set to a location other than `/spec/mailers/preview`. This does not force `ActionMailer` to load when the Railtie runs by removing the `defined?` check. This is necessary because the `ActionMailer` class only loads it's settings once, after it is first loaded. If we load the class in our Railtie any custom settings declared in a config block in an initializer will be ignored. An improved spec suite for the different permutations of availability of action mailer previews is included as well.
cupakromer
force-pushed
the
update-action-mailer-railtie
branch
from
74b95f2 to
f61100e
Compare
cupakromer
added a commit
that referenced
this pull request
Mar 18, 2015
Fix action mailer preview path setup.
Merged
|
Hi, rspec-rails 3.2.2 is broken with Rails 3.2.21 (and probably Rails 3.x) as the test to configure Resulting in the following error at server start:
I believe this PR is responsible for this break? |
|
same here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unnecessary warning about a preview path set to a
location other than
/spec/mailers/preview.This does not force
ActionMailerto load when the Railtie runs byremoving the
defined?check. This is necessary because theActionMailerclass only loads it's settings once, after it is firstloaded. If we load the class in our Railtie any custom settings declared
in a config block in an initializer will be ignored.
An improved spec suite for the different permutations of availability of
action mailer previews is included as well.
Resolve #1313, #1325