rails_example_group: don't include RSpec::Rails::FixtureSupport if it's not defined #1407
Conversation
FixtureSupport may not be defined if defined?(ActiveRecord::TestFixtures) == false. This is done in lib/rspec/rails/fixture_support.rb . If FixtureSupport isn't defined, the line that tries to include it will throw an error. Only include it if the class is defined.
| @@ -11,7 +11,7 @@ module RailsExampleGroup | |||
| include RSpec::Rails::MinitestLifecycleAdapter if ::Rails::VERSION::STRING >= '4' | |||
| include RSpec::Rails::MinitestAssertionAdapter | |||
| include RSpec::Rails::Matchers | |||
| include RSpec::Rails::FixtureSupport | |||
| include RSpec::Rails::FixtureSupport if RSpec::Rails::FixtureSupport rescue false | |||
There was a problem hiding this comment.
If you want to check if RSpec::Rails::FixtureSupport is defined then if defined?(RSpec::Rails::FixtureSupport) is a lot nicer than rescue false, but I'm unsure why this is necessary
There was a problem hiding this comment.
We actually specifically check for if defined?(ActiveRecord::TestFixtures) and make this module a no op if so.
|
I think this out dated vs |
|
❤️ Sorry you ran into this. The fixture support file defines the constant, regardless of if module RSpec
module Rails
# @private
module FixtureSupport
if defined?(ActiveRecord::TestFixtures)
# Content here
end
end
end
endThis issue sounds like something is not calling Looking at the stack it seems ammeter is what is only attempting to load part of rspec-rails 😦. The fix should come from there. There are a multiple dependencies that need to be loaded and setup. Currently this is handled by rspec-rails when you We may well move in the direction of allowing components to be required stand alone; however, we will still have the base requirement that |
|
Thanks for the really complete and very helpful responses @JonRowe and @cupakromer . You're exactly right: ammeter is only requiring selected parts of rspec/rails. I'll submit a PR over there. |
If ActiveRecord::Fixtures isn't defined, then the line
include RSpec::Rails::FixtureSupportinrspec/rails/example/rails_example_groupthrows an error.I found this when I started to use the ammeter gem to help me write a spec for a generator.
The ammeter gem
requires 'rspec/rails/example/rails_example_group'which has the lineinclude RSpec::Rails::FixtureSupport.#1372 introduced a conditional around the definition for RSpec::Rails::FixtureSupport (in
rspec/rails/fixture_support.rb) so that the class is not defined if ActiveRecord::TestFixtures isn't defined. So when theinclude RSpec::Rails::FixtureSupportline inrspec/rails/example/rails_example_groupis evaluated, an error is thrown since RSpec::Rails::FixtureSupport was never defined. This include line needs a conditional to check for this situation. I tested this correction:include RSpec::Rails::FixtureSupport if RSpec::Rails::FixtureSupport rescue falseand it works.Here's the environment and generator spec test file that shows the error:
Ruby 2.1.5p273
Rails 4.2.1
rspec (3.3.0)
rspec-rails (3.3.2) [I also tested master; same error occurs, same fix works]
ammeter (1.1.2)
spec_helper.rb and rails_helper.rb have defaults. No modifications were made to the originally installed files.
Generator spec test file:
Stack trace with the error:
(I'm using RubyMine so a bit of that cruft is in the trace output.)