Add explicit access control tags to docs #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the commit, docs for both RSpec::Rails::Matchers#be_a_new and RSpec::Rails::Matchers#be_new_record incorrectly indicated that the methods were private. This commit corrects this issue, following the pattern used here: https://github.com/rspec/rspec-rails/blame/1fb6f9f642e887df1b1ee344594de02d7de3b3fe/lib/rspec/rails/matchers/have_http_status.rb#L329 (f6c277f) Fixes #1413
|
There's no harm in this but RDoc.info is running an out of date version of yard and therefore wrong, one of these actually renders ok already:
|
JonRowe
added a commit
that referenced
this pull request
Aug 7, 2015
Add explicit access control tags to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the commit, docs for both RSpec::Rails::Matchers#be_a_new and
RSpec::Rails::Matchers#be_new_record incorrectly indicated that the
methods were private.
This commit corrects this issue, following the pattern used here:
https://github.com/rspec/rspec-rails/blame/1fb6f9f642e887df1b1ee344594de02d7de3b3fe/lib/rspec/rails/matchers/have_http_status.rb#L329
(f6c277f)
Fixes #1413